MultiNode Integration: TOML Configurations #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
had a problem deploying
to
integration
GitHub Actions
Error
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
aalu1418
reviewed
Oct 2, 2024
|
|
||
| type MultiNode struct { | ||
| // TODO: Determine current config overlap https://smartcontract-it.atlassian.net/browse/BCI-4065 |
There was a problem hiding this comment.
what was the result of checking for shareable config?
There was a problem hiding this comment.
Did not end up using any shared configs.
There was a problem hiding this comment.
It would be nice to reuse the config across different chains. The EVM case might be a bit complex, but for new integrations like Aptos/Tron, it does not make sense to duplicate this code.
Could you create a follow up ticket to address that?
There was a problem hiding this comment.
Yeah sounds good, we can extract this to the framework repo when doing the extraction.
pkg/solana/config/toml.go
Outdated
Comment on lines
289
to
291
| func (c *TOMLConfig) MultiNodeConfig() *MultiNodeConfig { | ||
| return &c.MultiNode | ||
| } |
There was a problem hiding this comment.
is this still needed if we just use c.MultiNode?
There was a problem hiding this comment.
This wrapper is needed in order to allow the config names to be public, while also having the required functions names which are the same.
|
can you also link the core PR in PR description? it was buried in the test/deployment events |
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
dhaidashenko
approved these changes
Oct 3, 2024
aalu1418
approved these changes
Oct 4, 2024
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
DylanTinianov
temporarily deployed
to
integration
GitHub Actions
Inactive
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added required TOML configurations for MultiNode integration.
Closes: https://smartcontract-it.atlassian.net/browse/BCFR-302
Core Bump Solana + Fix Tests PR: smartcontractkit/chainlink#14575
Requires Dependencies
This PR is a follow up to the MultiNode Initial Setup PR: #824